search

micha-silver / MODIS-download

Download MODIS tiles for eLTER sites
1 stars 1 forks source link

inclusion of functions in ReLTER #1

Closed oggioniale closed 2 years ago

oggioniale commented 3 years ago

Dear @micha-silver, it would be interesting to be able to include these functions in the ReLTER package. What do you think?

micha-silver commented 3 years ago

Yes, for sure. Although these functions were designed for a specific goal, not really generic. Would you want have a zoom, and discuss in general further improvements to ReLTER?

micha-silver commented 3 years ago

Alessandro: Here are three suggestions that I would like to discuss with you for ReLTER:

  1. A function to acquire CORINE grids from SDI Europe: https://sdi.eea.europa.eu/datashare/s/EriZXb4XSRzjSyR/download. AFAIK, the 2012 and 2018 grids are directly downloadable. This function would take a deimsid as parameter, and clip the CORINE grid to the site boundary.
  2. A function to acquire higher resolution landcover, and NDVI from maps.opendatascience.eu: https://data.opendatascience.eu/geonetwork/srv/eng/catalog.search#/home. Again, with a deimsid parameter, the data would be returned clipped to the site boundary.
  3. I think that all the getSite* functions could be merged into one, with an additional function parameter category. Based on the category parameter, the function would get either general info, contact info, infrastructure, boundaries, environment characteristics, etc. I believe this would be more user-friendly.

Regards, Micha

oggioniale commented 3 years ago

@micha-silver thanks for your suggestions.

I think that your suggestions are absolutely to be taken into account and to be implemented fast. However, I think it is necessary to have a stable version of the package, to be presented to eLTER community (also with a post in a eLTER and ILTER news letters) and published, as soon as possible (even if only for CRAN). So, if this functions (that you suggest) or the functions already done into this github repo, are easily implemented or can be easily included we can work in this way; otherwise I would focus on dissemination of the package.

About next functions to be make. I think that will be necessary for the user get raw dataset stored into DEIMS-SDR. But often these datasets present some problems: the information provided in DEIMS-SDR if not the same for all datasets (look the issues https://github.com/oggioniale/ReLTER/issues). Without harmonization of the dataset DEIMS-SDR metadata will be impossible to do that.

micha-silver commented 3 years ago

Hi @Ale: (Sorry for the slow response) FIrst, regarding a stable version on CRAN, you know the FOSS saying: "Release early, release often". So if you feel it's ready, go ahead.

However I do think that there are plenty of improvements that could be added fairly quickly. For example, I think that I could have those suggestions that I mentioned ready in a few weeks, Most are already written, more or less, in that demo that I did a year ago for cropping CORINE and MODIS images. And my additional idea of merging all your getSite*() functions into one, with an addition parameter "category" to choose what category of information to get from DEIMS could also be implemented easily: the existing functions are all mostly identical, so one generic one could be written from the existing code. If you agree with these ideas, I can go ahead and put something into the dev branch for testing...

oggioniale commented 3 years ago

Hi @micha-silver, I agree about the the saying FOSS! However, I implemented the get_site_info with category. I need to finish the test and after I can deliver in dev branch. About aspect about CORINE and MODIS, I agree please go ahead. Ale

micha-silver commented 3 years ago 
body p { margin-bottom: 0cm; margin-top: 0pt; } 

On 03/11/2021 09:51, Alessandro Oggioni
  wrote:

  Hi @micha-silver,
    I agree about the the saying FOSS!
    However, I implemented the get_site_info with category. I need
    to finish the test and after I can deliver in dev branch.

Terrific!

    About aspect about CORINE and MODIS, I agree please go ahead.

OK, I'm on it. :-)

    Ale
  —
    You are receiving this because you were mentioned.
    Reply to this email directly, view it on GitHub, or unsubscribe.
    Triage notifications on the go with GitHub Mobile for iOS or Android.

  [

{ @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/micha-silver/MODIS-download/issues/1#issuecomment-958718522", "url": "https://github.com/micha-silver/MODIS-download/issues/1#issuecomment-958718522", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

--

Micha Silver Ben Gurion Univ. Sde Boker, Remote Sensing Lab cell: +972-523-665918 https://orcid.org/0000-0002-1128-1325