Major code refactor - Githubissues

micha / resty

Little command line REST client that you can use in pipelines (bash or zsh).

MIT License

2.65k stars 143 forks source link

Major code refactor #50

Closed AdrieanKhisbe closed 7 years ago

AdrieanKhisbe commented 9 years ago

Code was refactored to be made more readable, maintenable, and extendable.

resty function was split in two:

resty : method to set up the host target
resty-call: to perform a call on the target (this is the method now called by the GET,POST,ETC functions

some coment where added in the code, and the inline &&where replaced with proper test. A switch case was added to handle the options.

You are welcome to do comments on this refactor. Very welcome. :)

(I might add shpec test before to merge this.)

AdrieanKhisbe commented 7 years ago

Major update on my PR, here is a recap: These many commits consist in setting up a test suite that is run on travis. These test are run on zsh and bash, both on linux and osx. Some modifications to the code had to be made to be working.

Many commits due to try and error process

AdrieanKhisbe commented 7 years ago

Status of the build can be see there: https://travis-ci.org/AdrieanKhisbe/resty/builds

AdrieanKhisbe commented 7 years ago

@all ( @micha @soyo42 )

Just rebased it, and I'm about to merge it in beta, see how it behaves, and then realease at last a v3.0 version

AdrieanKhisbe commented 7 years ago

@here @micha I'm about to merge and make a release candidate version