search

micha149 / gulp-maven-deploy

Gulp wrapper for the maven-deploy plugin
MIT License
12 stars 11 forks source link

adding finn code style module for formatting #7

Closed leftieFriele closed 9 years ago

leftieFriele commented 9 years ago

adding the FINN module and fixing contrib config

leftieFriele commented 9 years ago

@gregersrygg @sveisvei @phillipj can I haz merge?

phillipj commented 9 years ago

Ahh, you're too patient @leftieFriele, thanks for reminding us :+1: You're aaaaalmost there :dancer:

gregersrygg commented 9 years ago

Sorry, didn't see this pull-request. Looks like a good improvement, but there's a typo in the test-command in package.json. Remove the comma (and preferably the unnecessary path to finn-js-code-style), and this is good to go :+1:

Btw. We don't use this anymore at FINN. Do you want your child back @leftieFriele?

micha149 commented 9 years ago

Just for understanding: finn-js-code-style is only a jshint preset what people from FINN.no are using?

leftieFriele commented 9 years ago

yeah, that's what it is. you should probably just remove it.

On Wed, Jun 3, 2015 at 10:39 AM, Michael van Engelshoven < notifications@github.com> wrote:

Just for understanding: finn-js-code-style is only a jshint preset what people from FINN.no are using?

— Reply to this email directly or view it on GitHub https://github.com/micha149/gulp-maven-deploy/pull/7#issuecomment-108247822 .

Espen Dalløkken

micha149 commented 9 years ago

But I like the code style changes made in the PR :smile: