michael-fadely / sadx-dc-lighting

Sonic Adventure 1 palette lighting for SADX PC.
MIT License
39 stars 3 forks source link

Water objects are not palettized #19

Closed PiKeyAr closed 7 years ago

PiKeyAr commented 7 years ago

In SA1, several ocean/water objects have a stage base/specular palette. In SADX, they seem to ignore lighting altogether. There are only a few cases that need adjustment, though. 1) Emerald Coast ocean 2) Station Square ocean/sewers water (sewers in main area only) 3) Mystic Ruins ocean in the main area 4) Past ocean in acts 2-3 5) The ocean in boss arenas (Egg Hornet, Zero, E-101MK2)

It's likely that palettizing the water in Adventure Fields will greatly improve the look of the ocean at different times of day. Places like the EC/MR Chao Garden have the ocean as landtable objects, so no specific fix is necessary for those.

PiKeyAr commented 7 years ago

While looking for ocean drawing functions to disable them in the DC mods, I was able to identify all functions that draw ocean/water in different levels. Here's a list of them: 4F8A30 Emerald Coast 51C440 Egg Carrier 532500 Mystic Ruins 542850 Past 56CC30 E101 mk2 572270 Egg Hornet 587E10 Zero 631140 Station Square 718C30 Chao gardens (I think this is the water in SS garden, possibly MR too)

PiKeyAr commented 7 years ago

I no longer consider this an issue because: 1) Rather than messing with the FVFStruct_H_B things and trying to palettize them, water lighting effects can be achieved with a simple texture edit, so it's trivial to make water brighter in Past 2 and darker in Past 3. 2) Station Square uses separate textures for day/night and evening water. All in all I think it's just not worth the trouble, especially because the same results are easily obtainable with simple texture edits.