search

michael-fadely / sadx-dc-lighting

Sonic Adventure 1 palette lighting for SADX PC.
MIT License
39 stars 3 forks source link

lightning shield graphical glitch #31

Closed Thesch28 closed 7 years ago

Thesch28 commented 7 years ago

When I use this mod I get a weird glitch with the lightning shield in some levels I have only seen this on Sky Deck and Lost World Here's a picture. http://oi65.tinypic.com/otoghw.jpg those white boxes are moving all around the shield like if some textures of the shield got white or something sometimes I even seen them in yellow maybe this has something to do with stages with many lighting or fog effects because this glitch only happens on levels that have many effects like these 2.

michael-fadely commented 7 years ago

Well, that makes 3 people who have had this bug so far. Unfortunately I'm completely unable to reproduce this on my system, so it probably won't be going away any time soon. Would you happen to be playing with an nvidia or intel GPU? I have an AMD GPU in my system, but the only other reports I've had are from systems with non-AMD GPUs.

In any case, I appreciate the report.

Thesch28 commented 7 years ago

I so is more like a compatibility Issue with some GPUs. Other than that and some missing DC bosses effects (That have been reported already) the mods looks great. If I see more glitches or things missing I'll make sure to report them.

ghost commented 7 years ago

Hi,

Same bug, same locations. It also happens in Final Egg, notably in the last tube Sonic runs down before you hit the switch that triggers the "Level 2 isolation wall opened" announcement. It's not just white and yellow, I've had it be blue (well, cyan) before, too--it's different colors in different area. Unfortunately pausing the game makes it go away, though it returns immediately after unpausing (I have the pause-hide mod so it's not obscured). NVidia GT 750M here.

It's extremely consistent in Lost World. Just grab a lightning shield and it will happen a lot beginning around the top of the cylindrical water room (the big room with the rising water, sea serpent, and the 3 switches) and into the mirror room. I actually can't get it to not happen there. Might be worth noting that at the top of the cylindrical water room, it's blue.

In Lost World, it's also particularly rampant (and as a yellow square this time) towards the beginning of the mirror room, where it triggers when one of the blocking doors goes up (the ones that lift up when you stand right in front of them). It seems to trigger as the door moves, and then stops. Going back and retriggering the door does make it happen again.

Love your mods, btw. SADX almost feels like a whole new game!

michael-fadely commented 7 years ago

Thanks for the detail. Having just tested it again though, I'm still unable to reproduce the issue, so I can't debug it myself.

For whoever is up to it, here's something to try: On line 309 of lantern.fx (in sadx-dc-lighting/system/lantern.fx), change ps_fog to ps_nofog and see if the issue persists. I'm honestly not sure that it's related since the colors don't match, though.

Other than that, the only thing that comes to mind is alpha checking, which can be disabled by commenting (or removing) lines 279-282.

ghost commented 7 years ago

No difference. Though, unrelatedly, the overall framerate went down significantly when I commented out the alpha checking.

RinMaru commented 7 years ago

So I finally have experienced the shield glitch myself I'm on AMD RX 480.

Strange thing is it only happens in certain areas. like it happens in skydeck ONLY in this area so far capture Sky Deck act 3 its happening capture happens in this area but only in certain spots

everything is fine here capture move up a bit look its back again capture

michael-fadely commented 7 years ago

You're right, I can consistently reproduce it in Sky Deck as well. Particularly when standing next to the falling spike balls and they spew out particles everywhere. Now let's see if I can actually fix it...

michael-fadely commented 7 years ago

I've added a fix that appears to eliminate it on my system. If those affected could test 1.1.50-master, it would be appreciated.

cheatfreak47 commented 7 years ago

As I said on IRC, can confirm that fix worked for me. 👌

LimitCrown commented 7 years ago

The issue with the lightning shield is no longer present for me with this update.

ghost commented 7 years ago

This used to happen to me in Sky Deck, Lost World, and Final Egg ever since v1.0. With this patch? Not anymore… Problem is finally gone. Thank you!

michael-fadely commented 7 years ago

Thanks for testing everyone! Finally fixed.