michael-fadely / sadx-dc-lighting

Sonic Adventure 1 palette lighting for SADX PC.
MIT License
39 stars 3 forks source link

Ice Cap Icicle & Skydeck Fence + Platform Texture #35

Closed ghost closed 7 years ago

ghost commented 7 years ago

Posting on both pages.

Ice Cap Icicle has different color. http://screenshotcomparison.com/comparison/199783

Fence seems to ignore lighting (?) There is a different looking texture on platform. That ceiling crane thingy has different position of texture (?) http://screenshotcomparison.com/comparison/199782

michael-fadely commented 7 years ago

This looks like a mix of alpha issues and lack of texture mirroring, which is better suited for the sadx_dreamcast repo.

The lack of lighting on those rails could actually be due to incorrect palette selection though, so it's worth investigating. It's also interesting to see the subtle lighting differences overall, which could be a fault in the palette interpolation system.

Thanks for the report.

PiKeyAr commented 7 years ago

I think the icicles are like that because of palette selection, while everything else is correctable on my end. The fence does look like it ignores lighting, and the texture mirroring problem can be resolved by reimporting the DC model of that object.

PiKeyAr commented 7 years ago

After removing the "ignore light" flag on the rails/fence, I found out that palette selection is also involved. Since some rails are landtable objects, and others are SET objects, they are forced to load different palettes, and lighting looks different in the areas where they are joined together. To fix this, a palette selection method needs to be implemented in the lighting mod, particularly two things:

1) "Dreamcast mode" for landtable objects, which is basically what I requested in #20 2) A way to set palette indices manually for certain objects/models/materials/whatever. I'd be willing to go through all the objects/materials and adjust them manually when this is implemented.

RinMaru commented 7 years ago

I think this can be closed it seems these issues were fixed awhile back