search

michael-fadely / sadx-dc-lighting

Sonic Adventure 1 palette lighting for SADX PC.
MIT License
39 stars 3 forks source link

Red PAST #45

Closed RinMaru closed 6 years ago

RinMaru commented 7 years ago

Using the latest build of DC Lighting and Mod loader with the DC Conversion Mods. In Amy's story after beating Hot Shelter the game will bring you to the Past but it will all be in RED Lighting. After exiting the game and going back in the problem is gone. I've been skipping the cutscenes perhaps I tripped something during the transition?

supercoolsonic commented 7 years ago

I encountered something like this in Sky Deck once. I logged it in one of my lists. PkR thought it might be a test palette. Not sure what triggers it, or how to fix it.

michael-fadely commented 7 years ago

The lighting is supposed to be generally red with some orange, and it's supposed to have a fading effect. If that's not the case though, then we definitely have a bug on our hands. Also, when you say "latest build", are you referring to the latest development build?

RinMaru commented 7 years ago

yea I was using the 1.1.27 build i've run into other errors like the outside of videos (Blacks Bars) turning blue for instance but i think it only happens when skipping them or cutscenes. After experiencing the RED PAST I quit the game and started it back up in Windowed mode and since it loads you directly into the PAST with no cutscenes the error did not occur again

michael-fadely commented 7 years ago

Interesting; I'll take a look when I can. Thanks for the info.

michael-fadely commented 7 years ago

I'm unable to reproduce this issue. Can you check that it still happens?

RinMaru commented 7 years ago

yea ill run through it again

RinMaru commented 7 years ago

This can be closed I was unable to get it again in the latest Release. I think it just randomly bugged that one time.

PiKeyAr commented 7 years ago

I was able to reproduce this by beating Knuckles' story and then playing through Amy's story until the moment she goes to the Past. I think this happens because something Past fire-related gets stuck after Knuckles' cutscene and doesn't reset when Amy goes there. The issue only happens if you try to beat multiple character stories without restarting the EXE.

PiKeyAr commented 6 years ago

Could be related https://twitter.com/shaddytheguy/status/895112143032287233

Shaddytheguy commented 6 years ago

I don't know what could have triggered this version of what's going on. I updated the lantern engine mod via the loader, and when I saw it was crashing on the character select screen, I grabbed d3d8to9.dll, and it continued to not work. Then, I tried deleting the old copy of the mod and redownloading it off of git, and after replacing d3d8 again it finally worked properly, but after finishing Lost World as Sonic the past had that weird effect where it would fade back into the regular lighting (not on character models though, as you can see). So I really dunno if it's something on my end from a wrong version of the mod or d3d8 (which it could be, I always feel like I have to navigate a labyrinth to download stuff off git). That said, it's convinced me to use DC style water for right now because the neon blue DX water is distracting enough when it's not having weird lighting effects.

I'd already beaten Tails story and gone through Knuckles' opening cutscene, but I'd restarted the exe before this new stuff started happening, and when I did the rest of Knuckles story (halfway through typing this, infact) to see if it happened again, it was working properly. I might add that beforehand, sky deck was bizarrely dark, like it had the Egg Carrier's lighting stuck onto it or something. Unfortunately I wasn't able to get a screen of this, and replaying it in trial mode, it didn't have any such visuals.

michael-fadely commented 6 years ago

Hm, strange. I guess this will need some debugging. Thanks for the information. If you manage to narrow it down further of course, let me know!

PiKeyAr commented 6 years ago

How to reproduce a similar-looking thing: start in Trial mode, go to Sonic's Sky Deck and wait for the palette to change to dark, then exit while it's still dark and start Adventure Mode as Super Sonic. When you go to the Past you'll get this: image

michael-fadely commented 6 years ago

It seems as though--as usual--Sky Deck was indirectly the cause of the issue.

I've pushed a change that should address this issue. I'm no longer able to reproduce it with the steps outlined by @PiKeyAr, but it needs testing with the steps described by @Shaddytheguy.

For those able to test it, the build with this change is available here.

michael-fadely commented 6 years ago

Another fix has been pushed to fix the related bug where Sky Deck gets stuck permanently dark. Build available here.

this is all sky deck's fault

RinMaru commented 6 years ago

After a recent playthrough today the bug seems to be fixed

michael-fadely commented 6 years ago

OK, I'm going to consider this fixed!