michael-fadely / sadx-dc-lighting

Sonic Adventure 1 palette lighting for SADX PC.
MIT License
39 stars 3 forks source link

Request for a switch to disable built-in vcolors for non-landtable models #50

Closed PiKeyAr closed 7 years ago

PiKeyAr commented 7 years ago

This is more of a Dreamcast accuracy issue than a proper feature request, but still. Almost all models in SADX have built-in vertex colors, which are used for "lighting". SA1 models seldom use vcolors (if at all), so their vertex colors are usually just white. If the PL mod doesn't ignore built-in model vertex colors, the models' lighting will be comprised of both built-in and palettized colors, which isn't accurate and I think it's also why some of the "it's still not bright enough" complaints are showing up. There are two ways around this - either restore all SA1 models for all objects, which is kinda unrealistic, or add an option to the PL mod to force all model vcolors to be always white. On the other hand, vcolors specific to landtable models should be preserved I think, because SA1 landtables are completely restored by the DC mods anyway, and because they are sometimes used in SADX for non-lighting stuff - for example the color of the sea in Station Square and Egg Carrier Chao Garden.

PiKeyAr commented 7 years ago

Since this is implemented in the API, I think it can be closed now.