search

michael-fesselmeyer / ember-super-rentals

1 stars 0 forks source link

Prettier failures #24

Open jordpo opened 1 year ago

jordpo commented 1 year ago

Can you fix the prettier lint errors? That should fix your pipelines (both lint and test).

michael-fesselmeyer commented 1 year ago

I made some changes to my prettier config in the .prettierrc.js file that seems like it fixed my linting issues.

Also added a few style changes to personalize it a little so it doesn’t look as much like a tutorial clone.

Converted a few files into typescript also, but I’m still having problems with my rental-rating-test.js not working properly despite there being no bugs on the page with the rental rating.

Make detailed PRs for all of these things with more detail available

On Aug 6, 2023, at 8:34 PM, Jordan Morano @.***> wrote:

Can you fix the prettier lint errors? That should fix your pipelines (both lint and test).

— Reply to this email directly, view it on GitHub https://github.com/michael-fesselmeyer/ember-super-rentals/issues/24, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO7UGUFPPTVI5FRKVHW6HFDXUAZZLANCNFSM6AAAAAA3GH6PQM. You are receiving this because you are subscribed to this thread.