michael-hack / bulma-calendar

Bulma's extension to display a calendar
MIT License
286 stars 165 forks source link

Year buttons not appearing #40

Closed pelted closed 6 years ago

pelted commented 6 years ago

@kaizermd mentioned this in #37 but it is a separate bug.

I first noticed the missing buttons when I implemented the calendar on a test form. They also do not appear in the demo site. Overlay also makes no difference.

Tested with:

pelted commented 6 years ago

Just noticed #34 that was closed and commit 1d7c1f6 which is the cause of the regression. Since Bulma provides support for:

Maybe a better solution would be to allow the user to pass an iconSet property to the constructor. Then the the JS can handle switching out the icons based on the chosen set. This way the UI stays uniform to the users website icon choices without making an assumption of FA, or even embedded SVG.

If interested I could do a PR for this change.

Wikiki commented 6 years ago

Hi @pelted,

Great idea. I'm interested by a PR for that.

Regards

Wikiki commented 6 years ago

Your PR has been integrated. Thank you ;-)