search

michael-lazar / gemini-diagnostics

A torture test for gemini servers
MIT License
25 stars 5 forks source link

Return error if tests fail #3

Closed tinywombat765 closed 3 years ago

tinywombat765 commented 3 years ago

It's be helpful if test script returned 1 or something when it exited if any tests failed so it could be used as an automated test. I'm planning to implement this myself but was wondering if you had any suggestions on how to go about it. I haven't looked through your code much yet.

tinywombat765 commented 3 years ago

Maybe add a success param to BaseCheck, make log_test, log_error and the assert functions methods and make them flip the success param

michael-lazar commented 3 years ago

I think that's a fine idea. It feels a little hacky, but then again the whole script feels a little hacky 🤷‍♂️

Added in e7704294b13f455b368b29759fe33e6ace2543b1