search

michael-lazar / rtv

Browse Reddit from your terminal
MIT License
4.64k stars 274 forks source link

[Request] Open Thread of Submission link in browser #516

Open igor-krawczuk opened 6 years ago

igor-krawczuk commented 6 years ago

Is here a way to open the discussion of a submitted link from within rtv? Like Shift+o, or Shift+Enter? Currently it seems both o and enter in subreddit and submission mode open the submitted link.

If Shift+o, Shift+Enter seems like a good keybinding, I can also submit a pull request sometime these weeks to implement this

michael-lazar commented 6 years ago

Hi! Could you give an example of the type of link that you're talking about?

igor-krawczuk commented 6 years ago

Hi, this for example is the comment link:

https://www.reddit.com/r/programming/comments/7z59kg/opensource_project_which_found_12_bugs_in/

for the submission link

http://ithare.com/c17-compiler-bug-hunt-very-first-results-12-bugs-reported-3-already-fixed/

michael-lazar commented 6 years ago

Thanks, got it. RTV actually used to have this functionality when pressing o in the submission page. It was removed due to popular demand. https://github.com/michael-lazar/rtv/issues/344

I'm on board with adding the feature back in as long as we use a secondary key binding like you suggested, shift+o sounds reasonable. Feel free to submit a PR.