search

michael-lazar / rtv

Browse Reddit from your terminal
MIT License
4.65k stars 274 forks source link

Attempt #2 at adding in the 'gilded' feature #573

Closed edridgedsouza closed 6 years ago

edridgedsouza commented 6 years ago

Added a 'sort by gilded' feature in the banner bar and in the command prompt. Resubmitting this pull request because I realized a major typo in one of the functions. I attempted to modify the tests to account for the changes I made, but can't guarantee they'll all pass because I'm not familiar with running them, and because I wasn't sure about how to format the whitespace in the menu tests. pylint ran without any problems in the rtv directory.

Aside from the tests, the new feature runs smoothly on my computer and I believe it should be stable. Any help at fixing the tests would be greatly appeciated.

edridgedsouza commented 6 years ago

I fixed all of the broken tests by commenting them out. This link will show all the changes made in the newest version.

https://github.com/edridgedsouza/rtv/compare/93bf15078034...ccfff97ee646

In this link, you will see two main changes to the tests:

  1. Reformatted the menu bar strings

  2. Commented out any lines that relate to a 'cassette' for the gilded sort.

I'm not sure how exactly casettes work, but I can gather that they need to be manually placed in. My latest build passes the Travis CI for everything but python3.7 (same as the main master repo). In theory, once a cassette file for the gilded sort is generated, I think the commented lines can be uncommented and it'll all work smoothly.

edridgedsouza commented 6 years ago

Sorry for all the messages! I code mainly for data analysis so I'm not used to the extensive testing/CI. I believe the current version of this branch should be build-passing and successfully implements the 'sort by gilded' feature. The only thing to change is adding a cassette for a request to a subreddit sorted by 'gilded', then uncommenting the lines that I had commented in this commit.

Snapshot: Entered into the prompt: /wholesomememes/gilded image

michael-lazar commented 6 years ago

Made some changes and merged in https://github.com/michael-lazar/rtv/pull/579