search

michael-lazar / rtv

Browse Reddit from your terminal
MIT License
4.64k stars 274 forks source link

Retry posting comment on timed out error #634

Open shanmukhateja opened 5 years ago

shanmukhateja commented 5 years ago

This request is an improvement towards #227 where a post is saved to /tmp/ directory until rtv had posted it successfully.

So, I was wondering if rtv would retry posting the comment on error or ask the user if they wish to retry posting. I am currently experiencing HTTP request timed out message quite often while browsing Reddit (maybe because of corporate firewall?).

I'm currently have to copy-paste the saved comment on a temp file at /tmp/ directory but this gets slightly annoying with having to do it multiple times. Although the current implementation tends to keeps things simpler, due to the recursive nature of receiving timed out errors, it is getting slightly annoying.

Hence, I believe automating this process would be a great addition to the overall UX of rtv.

I propose two ways;

michael-lazar commented 5 years ago

Good suggestion 👍

shanmukhateja commented 5 years ago

Happy to know you're on board. So what do you think is the best action during a request timed out? I'm leaning towards option 2 as it gives two default options that a user usually experiences.

cakesale commented 5 years ago

This also happens when trying to change subreddits. Would be great if rtv retried if there is a connection failure.