search

michael-lazar / rtv

Browse Reddit from your terminal
MIT License
4.64k stars 274 forks source link

RTV exits when user home page has no submissions #651

Closed cmtholm closed 5 years ago

cmtholm commented 5 years ago

When logging in to an account that follows no subreddits a message is displayed: │/r/front has no submissions│

Following this, any key press exits RTV. Seems a more explanatory message would be beneficial, as well as still giving access to the normal navigation commands for RTV. Or RTV should default to Popular, then allow the user to navigate from there.

As is, a user with no front page submissions must specify rtv -s "subreddit" to use the application

michael-lazar commented 5 years ago

RTV is currently unable to render an empty page because it doesn't know what to do with the cursor when there's no element to select. I agree that it's confusing from a UI perspective, and it would be better to have an empty page and allow the user to enter navigation commands. It's just such a small edge case that it's been hard to justify the amount of code necessary to fix it.

michael-lazar commented 5 years ago

I went ahead and added the fix that you suggested of defaulting to /r/popular instead of the user's front page.