michael-lazar / rtv

Browse Reddit from your terminal

MIT License

4.64k stars 273 forks source link

Add option to force opening links in new browser window #674

Closed pabloariasal closed 5 years ago

pabloariasal commented 5 years ago

669

Added an option to the config file, _force_new_browserwindow, which when set opens links in a a new window instead of a new tab in the running browser.

[Note] Option works with old config files. If the config file doesn't have this option defined the old behavior (open in new tab) will be performed.

michael-lazar commented 5 years ago

Thanks for the PR. I made a few requests for minor changes.

pabloariasal commented 5 years ago

Thank you for the review, @michael-lazar! I addressed the requested changes. I created separate commits because I'm not sure if one can do a force push here.

michael-lazar commented 5 years ago

Merged, thank you!