search

michael-maltsev / cheese-fork

A scheduling helper web application for Technion students
https://cheesefork.cf
GNU General Public License v3.0
50 stars 13 forks source link

Extract Zoom Lectures From הערות #34

Closed PNone closed 7 months ago

PNone commented 7 months ago

In the upcoming semester (202301), course 044102 has 2 lecture dates in its הערות, in the following format:

====================\\nחלק 2 (לבחירה אחד משני המועדים):\\n22.02, יום חמישי, 14.30-16.30, בזום\\n04.03, יום שני, 18.30-20.30, בזום\\n====================

Is it possible to parse it and add it to the calendar?

https://github.com/michael-maltsev/cheese-fork/blob/e74df47972a8bd1e6ec8f3ef165f3fe5f28642bc/deploy/course-manager.js#L56

PNone commented 7 months ago

@michael-maltsev Is it possible to add this edge case to the parser's logic?

michael-maltsev commented 7 months ago

As I said in https://github.com/michael-maltsev/technion-ug-info-fetcher/issues/2:

The best solution for that is to contact the course staff and ask them to improve the way the information is presented on the students portal page.

But now as I look at it, the comments say the following:

חלק 2 (לבחירה אחד משני המועדים): 22.02, יום חמישי, 14.30-16.30, בזום 04.03, יום שני, 18.30-20.30, בזום

As I understand it, it's either 22.02 or 04.03, i.e. one meeting only, not a weekly meeting. Therefore, it wouldn't be correct to add it to a calendar, which presents weekly events.

I'm closing the issue. If you think I'm missing something here, feel free to follow-up with a comment.

PNone commented 7 months ago

@michael-maltsev I would suggest to have a one time event in the calendar for these two zoom lectures if possible, similar to the events created for tests (except those ones can have hours as well).

Is it possible?

michael-maltsev commented 7 months ago

Tests can also have hours:

image

It's possible, but I don't believe that implementing this special case (and figuring out how to allow selecting between the two days) is worth it for this single course. Also I'm not sure that all users will want to see it in the corner near the exams.

PNone commented 7 months ago

Tests can also have hours:

image

It's possible, but I don't believe that implementing this special case (and figuring out how to allow selecting between the two days) is worth it for this single course. Also I'm not sure that all users will want to see it in the corner near the exams.

@michael-maltsev Ok. I was thinking about the calender export file as opposed to the tests section. But it indeed may not be worth it for this course on its own