search

michael-maltsev / cheese-fork

A scheduling helper web application for Technion students
https://cheesefork.cf
GNU General Public License v3.0
53 stars 12 forks source link

Contributing Prerequisites #40

Open PNone opened 3 months ago

PNone commented 3 months ago

Hey,

I would like to contribute to this project if I can.

For example, I would like to add support for a vscode devcontainer work environment. This will allow working on this project without the need to install tools like node or php directly on a dev's workstation.

Are there any prerequisites or requirements needed for a contribution to be valid or for it to be considered for a merge?

michael-maltsev commented 3 months ago

Hi,

There are no prerequisites. Contributions are welcome, but not all contributions are accepted. There are no strictly defined criteria, it's mostly my judgement call.

As for the vscode devcontainer work environment PR, I saw it, but I don't have experience with it, I don't feel that I'll find it useful, and I'm not willing to take ownership over it and maintain it. At some point, the PR was closed automatically due to changes in the repo's structure.

BTW, you don't need tools like node or php. You can run npm install to have a linter configured, but basically you can just open index.html to run CheeseFork locally, and start editing the frontend files in whatever editor you like.

PHP is needed for technion-ug-info-fetcher, Python is needed for technion-sap-info-fetcher, but these are separate repos, and now the submodule was removed too.

PNone commented 3 months ago

Hi,

There are no prerequisites. Contributions are welcome, but not all contributions are accepted. There are no strictly defined criteria, it's mostly my judgement call.

As for the vscode devcontainer work environment PR, I saw it, but I don't have experience with it, I don't feel that I'll find it useful, and I'm not willing to take ownership over it and maintain it. At some point, the PR was closed automatically due to changes in the repo's structure.

BTW, you don't need tools like node or php. You can run npm install to have a linter configured, but basically you can just open index.html to run CheeseFork locally, and start editing the frontend files in whatever editor you like.

PHP is needed for technion-ug-info-fetcher, Python is needed for technion-sap-info-fetcher, but these are separate repos, and now the submodule was removed too.

Fair enough :)

Btw, I once tried making an addition to the calendar module but had a bit of trouble figuring it out :sweat_smile:

Is it (or any other module) based on an existing library that I can maybe take a peek at to figure out how it works?

michael-maltsev commented 3 months ago

Are you referring to the course calendar component? It makes use of (an old version of) FullCalendar, but it has some extra logic of its own.

PNone commented 2 months ago

Are you referring to the course calendar component? It makes use of (an old version of) FullCalendar, but it has some extra logic of its own.

cool, thank you :)