search

michael-mosler / Pius-App-for-Android

GNU General Public License v3.0
1 stars 0 forks source link

Duplicate entries in course List #2

Closed Th3Ph4nt0m closed 3 years ago

Th3Ph4nt0m commented 3 years ago

While filling in the "Meine Kurse" list, every course is shown twice. If you leave the "activity" and go back in, they are only shown ones.

Th3Ph4nt0m commented 3 years ago

onResume is executed again after "standby", so the list display must be cleared once before each loading.

I'm on it.

Th3Ph4nt0m commented 3 years ago

Double-Entries in Course-List

Th3Ph4nt0m commented 3 years ago

Fixed in this commit

Th3Ph4nt0m commented 3 years ago

Request for review and merge if necessary @michael-mosler

michael-mosler commented 3 years ago

There is no PR in open state. Have you pushed and created a PR in this repo?

Th3Ph4nt0m commented 3 years ago

It was just one line so i pushed directly to the develop-branch, hope that was okay. Should i create a PR to the master?

michael-mosler commented 3 years ago

Nope, as develop is our main branch we will not have PRs based onto master. For now it's ok. But in future: Even a single liner may break the app. So, actually we should have Ps for any change.

Please move ticket to "Done" state.

Th3Ph4nt0m commented 3 years ago

Okay, many thanks! We will create subbranches for the next changes.