michael-reichenauer / GitMind

Windows UI Git client
MIT License
28 stars 3 forks source link

Caret position in commit dialog #7

Closed FantasticFiasco closed 6 years ago

FantasticFiasco commented 7 years ago

I would like to display the caret position in the commit dialog. For the description input I would also like to display the line index. I am planning to create a PR in the upcoming days.

I would also like to add a EditorConfig to the repo, can you tell me what tab size you are using in your code, because I realize that my Visual Studio is inserting spaces while the rest of the code base is using tabs.

michael-reichenauer commented 7 years ago

Ok, that sounds fine. An alternative that you might consider, would be to just add an indicator line below each text box that would function similar to the "Editor Guidelines" (VS extension). That would probably be easier to implement with just a line behind the text boxes and make the text boxes transparent. But if you prefer your proposal, then go ahead.

I usually use tab size 2, but with tabs, everyone can use whatever size they like.

FantasticFiasco commented 7 years ago

With a vertical line behind the text box I would have to calculate the horizontal distance the characters would occupy, is that correct?

What is the maximum character count for the subject and the description?

michael-reichenauer commented 7 years ago

No, I don't think so, it is most likely just a fixed number since the default boxes have fixed width to handle the recommended text widths (I don't know the numbers now, but can find out tomorrow).

michael-reichenauer commented 6 years ago

Nos, there are red indikator lines that indicate recomended width