search

michael-reichenauer / GitMind

Windows UI Git client
MIT License
28 stars 3 forks source link

Bug when creating pre-release tag #9

Open FantasticFiasco opened 6 years ago

FantasticFiasco commented 6 years ago

I just came across a bug in GitMind. If you tag a commit with v4.1.0-beta1, which is a valid SemVer 2.0 version, GitMind interprets that as v4.1.0.

I just found the bug when I created the following tag in my repo.

michael-reichenauer commented 6 years ago

I think you could just adjust your .gitmind file in the root of your repo. I cloned your repo and in the .gitmind file I changed the tag row to this: tag: https://github.com/FantasticFiasco/serilog-sinks-udp/releases/tag/{0} (v\d+.\d+.\d+(-beta\d*)?) And then restarted GitMind and the tag/tag link seems to work. You can adjust the regex to allow alpha or some other combination that you need as well. I will however consider changing how the tag is displayed. Maybe the part of the tag that is not matched by the regex could be shown as well to make the cause easier to understand, but that has some other implications as well. Thanks for mentioning issue this.