Closed medsouz closed 1 month ago
Good change, thank you. Makes complete sense, and if someone wants to have all the optimization, they can build accordingly.
@all-contributors add @medsouz for code
@michael-simons
I've put up a pull request to add @medsouz! :tada:
@michael-simons would it be possible to generate a new release now that this is merged? Our Dockerfile is broken without this fix due to a CPU extension mismatch on our CI runner
The earliest this Thursday, I am away from a computer, but happy todo so then.
Am 21.10.2024 um 21:35 schrieb Matt Souza @.***>:
@michael-simons https://github.com/michael-simons would it be possible to generate a new release now that this is merged? Our Dockerfile is broken without this fix due to a CPU extension mismatch on our CI runner
— Reply to this email directly, view it on GitHub https://github.com/michael-simons/neo4j-migrations/pull/1488#issuecomment-2427444517, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEAQL7GAXX4Y6B3IFCBW53Z4VCPXAVCNFSM6AAAAABQB53KR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRXGQ2DINJRG4. You are receiving this because you were mentioned.
Perfect, no rush! Enjoy your time away 😄
Release is out, jars on central, binaries on SDKMan and Homebrew.
-march=native
can improve performance but will add a hard requirement for every CPU extension present on your CPU. This can cause issues with older CPUs or CPUs from different vendors (AMD vs Intel).-march=compatibility
will ensure the best compatibility with a potential performance penalty. In my experience this is not usually noticable in applications like neo4j-migrations.If performance is a concern then another option would be to remove the flag and trust the defaults of GraalVM, which according to their docs are:
x86-64-v3 on AMD64 and armv8-a on AArch64