Closed michael-slx closed 2 months ago
There was another connection problem. First error 165018Z today, and last error 171340Z. I got a reconnection alert at 1715, due to it posting data over mqtt at the 5min archive interval.
The only thing I'd say isn't right is that there is no report of success at the same critical log level, once, following a critical report of failure. Perhaps that should be inferred, and this is just my preference. But obviously that is really not a big deal and the important thing is that it reconnected.
So I'd say merge this to master, please. Thanks for addressing my bug report in discussions and hoisting it to issues.
The same instance from the previous comment is still running. There have been no more 3x timeouts, just singles, so the recovery code isn't being invoked. But still, all is well.
Have you had any issues recently?
I haven't had a "reporting lost" alert and hence haven't looked which is a goog sign. Just went to get the logs.. There have been multiple instances of 3 failures, but the code is coping ok and recovers. So I think things are ok.
I would say I have enough experience, including with timeouts, to be as sure as I can be that the two commits are a huge improvement, so I recommend merging the bugfix/close-on-error to develop and then folding it into a release. (I'm not clear on how you are doing releases.) Thanks very much for addressing this. Let me know if I can do anything else to help. I still need to update this box to weewx 5, and it's not local, so things are a little tricky.
I have filed #46 and #47 for the two suggestions I made earlier, now edited out.
Discussed in https://github.com/michael-slx/weewx-weatherlink-live/discussions/41