search

michael-veksler / solver

0 stars 0 forks source link

Improve the cdcl_sat solver coverage #21

Closed michael-veksler closed 7 months ago

codecov[bot] commented 7 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e434ced) 96.11% compared to head (1425dc3) 96.15%.

Files Patch % Lines
fuzz_test/fuzz_all_sat.cpp 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #21 +/- ## ========================================== + Coverage 96.11% 96.15% +0.04% ========================================== Files 19 20 +1 Lines 1543 1561 +18 Branches 1119 1133 +14 ========================================== + Hits 1483 1501 +18 Misses 10 10 Partials 50 50 ``` | [Flag](https://app.codecov.io/gh/michael-veksler/solver/pull/21/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Veksler) | Coverage Δ | | |---|---|---| | [Linux](https://app.codecov.io/gh/michael-veksler/solver/pull/21/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Veksler) | `61.26% <51.57%> (-0.95%)` | :arrow_down: | | [Windows](https://app.codecov.io/gh/michael-veksler/solver/pull/21/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Veksler) | `99.34% <100.00%> (+0.30%)` | :arrow_up: | | [macOS](https://app.codecov.io/gh/michael-veksler/solver/pull/21/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Veksler) | `36.08% <27.65%> (-0.60%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Veksler#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

michael-veksler commented 7 months ago

Need to cover operator<<(ostream&, const discrete_domain&) and discrete_domain::to_string()

Actually, better move the code to a location shared with binary_domain