michael-veksler / solver

0 stars 0 forks source link

Improve coverage of domains and introduce domain concept #22

Closed michael-veksler closed 7 months ago

michael-veksler commented 7 months ago

Fix inconsistencies between domain classes which the domain concept uncovers.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (030f36f) 95.82% compared to head (b01178c) 96.11%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #22 +/- ## ========================================== + Coverage 95.82% 96.11% +0.28% ========================================== Files 18 19 +1 Lines 1509 1543 +34 Branches 1094 1119 +25 ========================================== + Hits 1446 1483 +37 + Misses 15 12 -3 Partials 48 48 ``` | [Flag](https://app.codecov.io/gh/michael-veksler/solver/pull/22/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Veksler) | Coverage Δ | | |---|---|---| | [Linux](https://app.codecov.io/gh/michael-veksler/solver/pull/22/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Veksler) | `62.20% <43.18%> (-0.30%)` | :arrow_down: | | [Windows](https://app.codecov.io/gh/michael-veksler/solver/pull/22/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Veksler) | `99.03% <100.00%> (+0.24%)` | :arrow_up: | | [macOS](https://app.codecov.io/gh/michael-veksler/solver/pull/22/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Veksler) | `36.67% <34.09%> (+0.09%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Veksler#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.