codecov-commenter
commented
8 months ago Codecov Report
All modified lines are covered by tests :white_check_mark:
:exclamation: No coverage uploaded for pull request base (
main@74dd4fe). Click here to learn what that means.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #4 +/- ## ======================================= Coverage ? 45.75% ======================================= Files ? 6 Lines ? 365 Branches ? 203 ======================================= Hits ? 167 Misses ? 191 Partials ? 7 ``` | [Flag](https://app.codecov.io/gh/michael-veksler/solver/pull/4/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Veksler) | Coverage Δ | | |---|---|---| | [Windows](https://app.codecov.io/gh/michael-veksler/solver/pull/4/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Veksler) | `48.75% <100.00%> (?)` | | | [macOS](https://app.codecov.io/gh/michael-veksler/solver/pull/4/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Veksler) | `18.37% <60.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Veksler#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/michael-veksler/solver/pull/4?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Veksler) | Coverage Δ | | |---|---|---| | [include/solver/binary\_domain.hpp](https://app.codecov.io/gh/michael-veksler/solver/pull/4?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Veksler#diff-aW5jbHVkZS9zb2x2ZXIvYmluYXJ5X2RvbWFpbi5ocHA=) | `93.22% <100.00%> (ø)` | |:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Calling max(dom) when dom.empty() is illegal. Instead, use dom.empty() to detect the fact that the iterator is at end(). Use assert() to detect the bug.