search

michael-veksler / solver

1 stars 0 forks source link

Make literals generic in the clause code. #40

Closed michael-veksler closed 3 months ago

michael-veksler commented 3 months ago

This is intended to support non-boolean literals in the future.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 98.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.28%. Comparing base (c731daf) to head (e0910d8).

Files Patch % Lines
include/solver/cdcl_sat_clause_impl.hpp 96.29% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #40 +/- ## ========================================== + Coverage 97.20% 97.28% +0.07% ========================================== Files 27 28 +1 Lines 1935 1950 +15 Branches 1145 1154 +9 ========================================== + Hits 1881 1897 +16 + Misses 15 14 -1 Partials 39 39 ``` | [Flag](https://app.codecov.io/gh/michael-veksler/solver/pull/40/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Veksler) | Coverage Δ | | |---|---|---| | [Linux](https://app.codecov.io/gh/michael-veksler/solver/pull/40/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Veksler) | `56.19% <75.00%> (+0.25%)` | :arrow_up: | | [Windows](https://app.codecov.io/gh/michael-veksler/solver/pull/40/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Veksler) | `99.43% <100.00%> (+0.06%)` | :arrow_up: | | [macOS](https://app.codecov.io/gh/michael-veksler/solver/pull/40/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Veksler) | `27.06% <19.64%> (-0.13%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Veksler#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.