michael / multiselect

jQuery UI Multiselect Widget
http://www.quasipartikel.at/multiselect
MIT License
557 stars 208 forks source link

selection / deselection has issues with jQuery 1.9 #143

Open michelgre opened 11 years ago

michelgre commented 11 years ago

jQuery 1.9 obsoleted the way boolean attributes such as 'selected' are handled. Thus the selection / deselection of ui.multiselect doesn't work properly anymore with some browsers (Firefox 18).

To reproduce:

Fix: Change the occurences of: attr('selected','selected') => prop('selected', true) removeAttr('selected') => prop('selected, false)

See http://bugs.jquery.com/ticket/13474 for a discussion about this issue (I did not refer to ui.multiselect there, but I opened the ticket there because of this problem here).

Thanks for ui.multiselect though !!!

yanickrochon commented 11 years ago

Will do! I had started replacing them but didn't see any errors on my side.

Note that you might also take a look at the next version of this widget, which does support jQuery 1.9

michelgre commented 11 years ago

Well it is not so easy to hit the error, it depends on some obscure behavior of some browsers, but they confirmed that we should not use attr() anymore.

And I was not aware of multiselect-2, so thanks for the link!

andrefagundes commented 10 years ago

Did the replacement and resolved. thank you

sjuhos commented 9 years ago

Thanx.

imadboy89 commented 9 years ago

thanks,