search

michaelKurowski / lokim2

An internet messenger that cares about privacy.
4 stars 0 forks source link

WIP: #97 Added disconnect in Room namespace #105

Closed MarcinGrzeszczak closed 5 years ago

MarcinGrzeszczak commented 6 years ago

Reference to related ticket: resolves #97 Description of changes: Removing entries from userToConnection Map when user is disconnected.

michaelKurowski commented 5 years ago

@MarcinGrzeszczak Is the solution working?

codecov[bot] commented 5 years ago

Codecov Report

Merging #105 into master will decrease coverage by 0.03%. The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
- Coverage   83.72%   83.69%   -0.04%     
==========================================
  Files          76       76              
  Lines        1137     1141       +4     
==========================================
+ Hits          952      955       +3     
- Misses        185      186       +1
Impacted Files Coverage Δ
src/server/ws-routes/controllers/Room.js 96.72% <100%> (+0.11%) :arrow_up:
src/server/utilities.js 82.85% <50%> (-2%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4dbc1b4...26e188f. Read the comment docs.