search

michaelKurowski / lokim2

An internet messenger that cares about privacy.
4 stars 0 forks source link

Create static files for webserver #61

Closed Jordan141 closed 6 years ago

Jordan141 commented 6 years ago

Create production build of current master frontend to serve as static files, as the proxy of localhost will fail in such an event, or find alternative solution.

Jordan141 commented 6 years ago

Created static files. https://github.com/michaelKurowski/lokim2/commit/a9f424d8037402a7a06c7c3df2813abb92cb44ca I suggest we deploy to heroku to test this effectively to guarantee that it operates as intended.

Jordan141 commented 6 years ago

I don't see any current route for delivering static files, adding backend label

michaelKurowski commented 6 years ago

@Jordan141 Please set up /public/ endpoint to serve your files. The change can be done in src/server/routes/router.js. You can look up how did we make it in case of /test endpoint.

We need it to be done quickly in order to set up E2E tests which have broadest coverage and are able to detect a lot of errors across the application.

michaelKurowski commented 6 years ago

Relevant branch: https://github.com/michaelKurowski/lokim2/tree/%2361-static-build-files

michaelKurowski commented 6 years ago

As for deploying on heroku, I'm not sure if we really need it. It can be checked locally. https://github.com/michaelKurowski/lokim2/issues/45 we have separated ticket for heroku.

michaelKurowski commented 6 years ago

@Jordan141 How's the progress, we need it to deploy app on heroku.