#1 Graph rendering - Githubissues

michaelKurowski / visual-knowledge-database

Convenient to navigate knowledge database, perfect for exploring your areas of interest

1 stars 0 forks source link

#1 Graph rendering #4

Closed michaelKurowski closed 4 years ago

michaelKurowski commented 4 years ago

TODO Rendering graph from data instead of generating nodes during rendering

michaelKurowski commented 4 years ago

TODO Laggs. The biggest source of laggs are captions and beziers that fade out on the border of rendering. Beziers at the edge could be just rendered lower, under a layer that would be covered with radial gradient

michaelKurowski commented 4 years ago

TODO Fix navigating directly to third-level nodes Children beziers could be also stored at nodes, so beziers at the edge could be animated

michaelKurowski commented 4 years ago

TODO Fix edge beziers not always showing up

Jordan141 commented 4 years ago

nice node modules

michaelKurowski commented 4 years ago

@Jordan141 ready for code review

michaelKurowski commented 4 years ago

Actually I'll refactor and optimize it first

michaelKurowski commented 4 years ago

TODO Laggs. The biggest source of laggs are captions and beziers that fade out on the border of rendering. Beziers at the edge could be just rendered lower, under a layer that would be covered with radial gradient

Actually after hiding of edge beziers the laggs still occur on mobile phones

michaelKurowski commented 4 years ago

@Jordan141 could you check whether it's laggy on your phone?

michaelKurowski commented 4 years ago

TODO animation malfunction after navigating to emYhGb... and then to hUM9J...

michaelKurowski commented 4 years ago

Alright @Jordan141 done, please CR

Jordan141 commented 4 years ago

Non-MVP Requests:

Right click should not perform the functionality of left click

Other than that I will approve the PR

Jordan141 commented 4 years ago

Bug found: If you click on the next node before the animation ends, you become unable to return to the previous level.

Console errors: 206konva.js:1058 Konva error: Tween constructor have `node` that is not in a layer. Please add node into layer first. error @ konva.js:1058 index.js:59 Uncaught TypeError: Cannot read property 'to' of null at hideAncestorNodes (index.js:59) at Animation.func (index.js:330) at Function.Animation._runFrames (konva.js:9082) at Animation._animationLoop (konva.js:9107)