search

michaelWuensch / BitBanana

Lightning Node Management for Android
https://bitbanana.app
MIT License
95 stars 11 forks source link

App crashes when trying to send payment to non-existent lightning address typed via keyboard #37

Closed bezysoftware closed 1 year ago

bezysoftware commented 1 year ago

Description

When trying to send a payment to non-existent lightning address AND you enter this address manually via keyboard, the app crashes (restarts to be exact). When you scan the same address with a QR code the app correctly shows an error prompt (e.g. 404).

Expected Behavior

The app should behave the same way when the lightning address is entered via keyboard as it does when scanning the address from a QR code - it should show a red prompt with error description. It shouldn't crash.

Actual Behavior

The app crashes.

Possible Fix

Steps to Reproduce

Send -> "blabla@blabla123.com" -> Continue -> App crashes

Context

I was trying to send a payment to someone (donation) but they had disabled their lightning address. The app would crash, restart and prompt for my finger print, which was confusing because at first I though it was asking me to confirm the payment, but I hadn't specified the amount yet.

Your Environment

michaelWuensch commented 1 year ago

Thanks for the bug report! I can confirm this still happens in the just released version 0.6.4. I will fix it asap.

michaelWuensch commented 1 year ago

I fixed the bug. Fix will be deployed with next release.

michaelWuensch commented 1 year ago

The fix was released with 0.6.5