search

michaelaltmann / get-your-refund

1 stars 5 forks source link

Problem: Greeters remain assigned to clients who are Ready for Review #13

Open plocket opened 3 years ago

plocket commented 3 years ago

When moving a client forward, you change the status and think you’re done, but you stay assigned to that client

Suggested in-the-moment solution:

Changing the status to Ready to Review should auto unassign yourself. Potentially could utilize the Take Action bookmarklet, and re-purpose it to unassign yourself on a status change to either Ready for Review, or Not Filing.

After-the-fact solution

May not be necessary with work on this and #11 so wait till the impact of those is assessed. If this is still relevant, make it into its own issue.

Icon warning about the status right next to name or the 'needs attention' dot on the 'Assigned' page and on the 'All clients' page.

See additional notes in doc.

plocket commented 3 years ago

Need to happen on the Take Action page when changing status and work with 'Send + Next', which will navigate to some arbitrary address.

michaelaltmann commented 3 years ago

If the state is being changed to "Ready for Review", do we think it is safe to unassign without first checking that the current user is currently assigned to the tax return? In other words, should we worry about a use case where greeter drops into the workflow on a tax return that is assigned to someone else?

michaelaltmann commented 3 years ago

Should I modify the behavior of the "Send" button as well as the "Send + Next" button?

michaelaltmann commented 3 years ago

Exactly which status should or should not trigger the unassign?

plocket commented 3 years ago

should we worry about a use case where greeter drops into the workflow on a tax return that is assigned to someone else?

I think that's a good question for the channel.

Should I modify the behavior of the "Send" button as well as the "Send + Next" button?

Yes, I think so.

Exactly which status should or should not trigger the unassign?

Setting a client to "Ready for Review" should trigger unassigning. Nothing else that I know of. I thought that's what we had said above already, though, so I'm not sure if I'm missing something.

michaelaltmann commented 3 years ago

Should "Not Filing" also trigger unassign? I would think so. What other statuses?