search

michaelaltmann / get-your-refund

1 stars 5 forks source link

squish: fails if sorting my assigned clients #32

Open akh8zm opened 3 years ago

akh8zm commented 3 years ago

So squish works on my "All clients" tab and my "Assigned clients" tab. When I sort them (by clicking the little headers at the top of the columns), squish still works on the "All clients" tab, BUT if I sort the "Assigned clients" tab, squish suddenly fails. Weirdly, if I go to the "All clients" tab and check "Assigned to me", I can sort them and squish successfully applies.

Since there's a workaround and it's not that important anyways, this isn't too big of an issue :) - Ashley, greeter

plocket commented 3 years ago

Thanks, @akh8zm! I'm reaching out on Slack to see if I can get some more details about what 'fails' means more specifically and the steps that are needed to reproduce this failure. Glad there's at least a work around!

akh8zm commented 3 years ago

Oh I finally figured out what this was! It's an issue with TamperMonkey, not squish. The existing header text for the TamperMonkey script (saying which websites to run it on) I had copied over from the FlagClient bookmarklet, which has the same issue. In the script header, you just need to add // @match https://*.getyourrefund.org/en/hub*. The asterisk makes sure it matches the new URL, which changes when you sort clients.