search

michaelarmstrong / SuperRecord

A small set of utilities to make working with CoreData and Swift a bit easier.
MIT License
366 stars 27 forks source link

Update project to work with swift 1.2 #16

Closed rromanchuk closed 9 years ago

rromanchuk commented 9 years ago

Compiles, and confirmed tests are passing

PGLongo commented 9 years ago

@michaelarmstrong SuperRecord doesn't compile with SDK 8.2.

Swift 1.2 will be released with SDK 8.3 so I think you should revert master and support Swift 1.2 in another branch.

rromanchuk commented 9 years ago

Sorry, bad pull request, i meant to merge this into a topic branch for swift 1.2 as @PGLongo mentioned

michaelarmstrong commented 9 years ago

ah crap... PGLongo, you're now contributor. Please could you go ahead and revert (i'm at work now).

michaelarmstrong commented 9 years ago

mind you, looking at the code, it looks very backwards compatible, as its just some casts and explicitness. Does it not work in todays Xcode?

PGLongo commented 9 years ago

@rromanchuk I have reverted the master. Can you make another PR to this branch feature/Swift1.2 ?

ikesyo commented 9 years ago

@michaelarmstrong Failable casts (as! operator) is a Swift 1.2 only thing. For better compatibility, we can use (result as? NSManagedObject)! pattern.