Closed jonesPD closed 4 years ago
Thanks for your PR's! My goal is to rework this library to have an much clearer API, and to be more easy to use and maintain, but all help is welcome!
great to hear. Does your rework change the working communication? I'm using comfoconnect together with a script for fhem and a slightly modified const.py.
Am So., 7. Juni 2020 um 19:00 Uhr schrieb Michaël Arnauts < notifications@github.com>:
Thanks for your PR's! My goal is to rework this library to have an much clearer API, and to be more easy to use and maintain, but all help is welcome!
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/michaelarnauts/comfoconnect/pull/26#issuecomment-640248409, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN3USCYUPOAKVE5DLCNCH3LRVPBRXANCNFSM4NXKLZAA .
I haven't coded it yet, but it will change the way the library will work.
why change a running system?
Michaël Arnauts notifications@github.com schrieb am So., 7. Juni 2020, 20:00:
I haven't coded it yet, but it will change the way the library will work.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/michaelarnauts/comfoconnect/pull/26#issuecomment-640256302, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN3USC464QZT6UNHQ6XYCRTRVPIVRANCNFSM4NXKLZAA .
To refactor it, make it easier to maintain, add features. You can still keep on using the tagged version you are using now.
Sure, I hope you will do a release before the big change. The last release 0.3 is from 27 Jun 2017 and in the meantime a lot of commits have been made. Many thanks for your great work!
Judging from the values I see returned by my Q350 and what I find in the Comfo Control app, it seems RMOT PropIds for heating and cooling need to be the other way around