search

michaelb / sniprun

A neovim plugin to run lines/blocs of code (independently of the rest of the file), supporting multiples languages
MIT License
1.5k stars 47 forks source link

Prolog support #127

Open michaelb opened 2 years ago

michaelb commented 2 years ago

Describe the language you want support for (compiler, specificities) prolog

Support Level to achieve bloc-level

Additional context wip; src/interpreters/Prolog_gnu.rs

michaelb commented 2 years ago

@tani I merged your PR and made appropriate adjustments to some things, but this work is not complete yet.

Could you re-sync your fork and see what has to be done to have a working Prolog interpreter? (at least having the test you wrote pass)

tani commented 2 years ago

@michaelb Okay! Thanks. I check it now.

tani commented 2 years ago

doc/Prolog_gnu

In my understanding, the naming rule of your project is as follows;

Prolog is a programming name. GNU Prolog and SWI Prolog are independent interpreters such as GCC and Clang. I mean, we should distinct SWI Prolog and GNU Prolog in some sense. Precisely speaking, we cannot use SWI Prolog to replace GNU Prolog because the interface is not compatible with the others.

I request you to add Prolog_swi again and update documents. Or, how about renaming Prolog_gnu to Prolog_original

CONTRIBUTING_REPL.md

This is the awesome document I wanted.

On L18 in CONTRIBUTING_REPL.md, we see the typo stdin/stdou/stderr. On L21, please remove the leading space for better markdown compliance.

michaelb commented 2 years ago

how about renaming Prolog_gnu to Prolog_original

Done, on the dev branch (re-sync your fork if you want to start from here). You're totally right, it's clearer.

This is the awesome document I wanted.

You're welcome. The small fixes you wanted are also on the dev branch

I request you to add Prolog_swi again

Oh, also. I'm the last person that would be offended, moreover I know that no one writes perfect english, but as a general rule in open-source, don't 'request' or 'demand'. 'Ask', or use softer words 'could you'/'would it be possible to'

tani commented 2 years ago

Thank you for listening to my comments. I'm sorry if my English makes me uncomfortable. I learned about more gentlemanly phrases.