Closed reavessm closed 11 months ago
At least the basics works:
Nice idea! Thank for contributing!
I'll do a more in-depth review asap
Thanks! I'll keep this in draft status until I get some of the other http verbs implemented but I'd love feedback, especially on other trait functions and dependency/feature related stuff
The http parser doesn't curently implement variable substitution, so we will need to upgrade the dependency version once https://github.com/Laeri/http-rest-file/pull/1 gets merged if we want that feature
Hi @reavessm , I 'fixed' a modification you made due to an incorrect comment of mine (error_truncate stuff, sorry). Do you agree with the latest commit on the 'http' branch I just pushed ?
(it does silently fails if the resp.into_string() errors out, but I don't see that happening in the real-world, or if it does, I hope the status (not-200?) will be indicative enough)
Oh, I like that! Thank you! That really cleans it up. I'll add that to this PR. I'm going to reopen this for review.
I also think we shouldn't rerun anything in case somethings fails. I can see a situation where you have three REST calls that you want to execute sequentially and if the second one fails, you don't want the third to run. Especially considering this isn't naming any of the requests, I think sequential order is important
I also think we shouldn't rerun anything in case somethings fails.
Fair enough
return
ing at the first failure should do the trick
@reavessm Are you satisfied with the state of your contribution ? As for me, this is good :-)
However, I'd like to do my own dev merge and add some cosmetics (update readme and doc) about HTTP support, so I can't give you permission to merge into master anytime you want via the review system. (Because of how most vim plugin manager works, the master branch has to be carefully synchronized with sniprun's binary releases)
@michaelb Yep! I can change this to be based on the dev branch. And if you need any help with docs I don't mind helping
Support for testing rest endpoint via sniprun
Following http file syntax