michaelbanfield / devise-pwned_password

Devise extension that checks user passwords against the PwnedPasswords dataset
https://rubygems.org/gems/devise-pwned_password
MIT License
156 stars 29 forks source link

Feature: Generators for module installation and controller modification #12

Closed michaelbanfield closed 6 years ago

michaelbanfield commented 6 years ago

Currently users need to write some code after installing this module, to hook the check into their model and optionally to add a controller change to warn existing users.

It would make the getting started experience simpler if we had generators to

  1. Add the check to their devise model
  2. Modify the ApplicationController with the sign in hook

It might also make sense to explicitly add our various config values/internationalization, along with comments about what they do. This would be a bit more explicit and means users dont have to dig into the code or our readme to see what they can configure