michaelbanfield / devise-pwned_password

Devise extension that checks user passwords against the PwnedPasswords dataset
https://rubygems.org/gems/devise-pwned_password
MIT License
156 stars 29 forks source link

Add missing tests for User.min_password_matches_warn #29

Closed TylerRick closed 4 years ago

TylerRick commented 4 years ago

I didn't see any tests for User.min_password_matches_warn — or even User.min_password_matches, for that matter :grimacing: — which makes me nervous as I'm changing things because I don't want to accidentally break any existing behavior. :sweat:

(These probably should have been included as part of #16.)

This PR was based on #28 to make my life easier (since I'm submitting a lot of PRs) but can easily be rebased as needed.