search

michaelbanfield / devise-pwned_password

Devise extension that checks user passwords against the PwnedPasswords dataset
https://rubygems.org/gems/devise-pwned_password
MIT License
156 stars 29 forks source link

Fail silently for Net::HTTP exceptions #4

Closed damonmorgan closed 6 years ago

damonmorgan commented 6 years ago

Some of the most common exceptions Net::HTTP requests raise are Timeout::Error, Errno::ECONNRESET and Net::HTTPBadResponse. Those are now ignored and do not prevent signing up.

The default Net::HTTP timeout setting for open and read is 60 seconds, which is too long to block a sign up for, so more reasonable defaults are set with the option to override them.

michaelbanfield commented 6 years ago

Thanks for this change, ill get it published to rubygems shortly