Upgrade to Angular 12 - Githubissues

michaelbazos commented 2 years ago

Thanks 👍

TomasKostadinov commented 2 years ago

@anikets43 Could you do the same for Angular 13 or provide instructions on how you upgraded the library to Angular 12? I tried to follow the steps on Updating Angular but ended up with the following errors:

tomas@Taika ~/code/angular-feather                                                                                                         [11:27:54]
> $ npx @angular/cli@13 update @angular/core@13 @angular/cli@13                                                                 ⬡ 16.13.1 [±master ✓]
The installed local Angular CLI version is older than the latest stable version.
Installing a temporary version to perform the update.
✔ Package successfully installed.
Using package manager: 'npm'
Collecting installed dependencies...
Found 33 dependencies.
Fetching dependency metadata from registry...
    Updating package.json with dependency @angular-devkit/build-angular @ "13.1.2" (was "12.2.10")...
    Updating package.json with dependency @angular/cli @ "13.1.2" (was "12.2.10")...
    Updating package.json with dependency @angular/compiler-cli @ "13.1.1" (was "12.2.10")...
    Updating package.json with dependency ng-packagr @ "13.1.2" (was "12.2.3")...
    Updating package.json with dependency typescript @ "4.5.4" (was "4.3.5")...
    Updating package.json with dependency @angular/animations @ "13.1.1" (was "12.2.10")...
    Updating package.json with dependency @angular/common @ "13.1.1" (was "12.2.10")...
    Updating package.json with dependency @angular/compiler @ "13.1.1" (was "12.2.10")...
    Updating package.json with dependency @angular/core @ "13.1.1" (was "12.2.10")...
    Updating package.json with dependency @angular/forms @ "13.1.1" (was "12.2.10")...
    Updating package.json with dependency @angular/platform-browser @ "13.1.1" (was "12.2.10")...
    Updating package.json with dependency @angular/platform-browser-dynamic @ "13.1.1" (was "12.2.10")...
    Updating package.json with dependency @angular/router @ "13.1.1" (was "12.2.10")...
  UPDATE package.json (1511 bytes)
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: workspace@6.1.0
npm ERR! Found: @angular-devkit/build-angular@12.2.10
npm ERR! node_modules/@angular-devkit/build-angular
npm ERR!   dev @angular-devkit/build-angular@"~13.1.2" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! dev @angular-devkit/build-angular@"~13.1.2" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: @angular/compiler-cli@13.1.1
npm ERR! node_modules/@angular/compiler-cli
npm ERR!   peer @angular/compiler-cli@"^13.0.0 || ^13.1.0-next" from @angular-devkit/build-angular@13.1.2
npm ERR!   node_modules/@angular-devkit/build-angular
npm ERR!     dev @angular-devkit/build-angular@"~13.1.2" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/tomas/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/tomas/.npm/_logs/2021-12-27T10_28_34_443Z-debug.log
✖ Package install failed, see above.

anikets43 commented 2 years ago

@anikets43 Could you do the same for Angular 13 or provide instructions on how you upgraded the library to Angular 12? I tried to follow the steps on Updating Angular but ended up with the following errors:

tomas@Taika ~/code/angular-feather                                                                                                         [11:27:54]
> $ npx @angular/cli@13 update @angular/core@13 @angular/cli@13                                                                 ⬡ 16.13.1 [±master ✓]
The installed local Angular CLI version is older than the latest stable version.
Installing a temporary version to perform the update.
✔ Package successfully installed.
Using package manager: 'npm'
Collecting installed dependencies...
Found 33 dependencies.
Fetching dependency metadata from registry...
    Updating package.json with dependency @angular-devkit/build-angular @ "13.1.2" (was "12.2.10")...
    Updating package.json with dependency @angular/cli @ "13.1.2" (was "12.2.10")...
    Updating package.json with dependency @angular/compiler-cli @ "13.1.1" (was "12.2.10")...
    Updating package.json with dependency ng-packagr @ "13.1.2" (was "12.2.3")...
    Updating package.json with dependency typescript @ "4.5.4" (was "4.3.5")...
    Updating package.json with dependency @angular/animations @ "13.1.1" (was "12.2.10")...
    Updating package.json with dependency @angular/common @ "13.1.1" (was "12.2.10")...
    Updating package.json with dependency @angular/compiler @ "13.1.1" (was "12.2.10")...
    Updating package.json with dependency @angular/core @ "13.1.1" (was "12.2.10")...
    Updating package.json with dependency @angular/forms @ "13.1.1" (was "12.2.10")...
    Updating package.json with dependency @angular/platform-browser @ "13.1.1" (was "12.2.10")...
    Updating package.json with dependency @angular/platform-browser-dynamic @ "13.1.1" (was "12.2.10")...
    Updating package.json with dependency @angular/router @ "13.1.1" (was "12.2.10")...
  UPDATE package.json (1511 bytes)
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: workspace@6.1.0
npm ERR! Found: @angular-devkit/build-angular@12.2.10
npm ERR! node_modules/@angular-devkit/build-angular
npm ERR!   dev @angular-devkit/build-angular@"~13.1.2" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! dev @angular-devkit/build-angular@"~13.1.2" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: @angular/compiler-cli@13.1.1
npm ERR! node_modules/@angular/compiler-cli
npm ERR!   peer @angular/compiler-cli@"^13.0.0 || ^13.1.0-next" from @angular-devkit/build-angular@13.1.2
npm ERR!   node_modules/@angular-devkit/build-angular
npm ERR!     dev @angular-devkit/build-angular@"~13.1.2" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/tomas/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/tomas/.npm/_logs/2021-12-27T10_28_34_443Z-debug.log
✖ Package install failed, see above.

Sure @TomasKostadinov I will do the upgrade. Thanks for checking with me

TomasKostadinov commented 2 years ago

@anikets43 That sounds great - could you please also document what steps you performed, so that we can redo these in future updates?

michaelbazos / angular-feather

Upgrade to Angular 12 #50