michaelbazos / angular-feather

A-la-carte integration of Feather Icons in Angular applications
MIT License
155 stars 38 forks source link

Angular 14 support #62

Closed dtrouillet closed 1 year ago

dtrouillet commented 1 year ago

Hello,

Can add support of Angular 14.

For information, stacktrace :

npm ERR! Found: @angular/common@14.0.0
npm ERR! node_modules/@angular/common
npm ERR!   peer @angular/common@"^14.0.0 || ^15.0.0" from @angular/cdk@14.0.0
npm ERR!   node_modules/@angular/cdk
npm ERR!     peer @angular/cdk@"14.0.0" from @angular/material@14.0.0
npm ERR!     node_modules/@angular/material
npm ERR!       @angular/material@"^14.0.0" from the root project
npm ERR!     @angular/cdk@"^14.0.0" from the root project
npm ERR!   peer @angular/common@"14.0.0" from @angular/forms@14.0.0
npm ERR!   node_modules/@angular/forms
npm ERR!     peer @angular/forms@"^14.0.0 || ^15.0.0" from @angular/material@14.0.0
npm ERR!     node_modules/@angular/material
npm ERR!       @angular/material@"^14.0.0" from the root project
npm ERR!     peer @angular/forms@">=9.0.0" from @ckeditor/ckeditor5-angular@4.0.0
npm ERR!     node_modules/@ckeditor/ckeditor5-angular
npm ERR!       @ckeditor/ckeditor5-angular@"^4.0.0" from the root project
npm ERR!     2 more (the root project, @ng-bootstrap/ng-bootstrap)
npm ERR!   14 more (@angular/material, @angular/platform-browser, ...)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"~13.1.1" from angular-feather@6.3.0
npm ERR! node_modules/angular-feather
npm ERR!   angular-feather@"^6.3.0" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: @angular/common@13.1.3
npm ERR! node_modules/@angular/common
npm ERR!   peer @angular/common@"~13.1.1" from angular-feather@6.3.0
npm ERR!   node_modules/angular-feather
npm ERR!     angular-feather@"^6.3.0" from the root project
npm ERR!
erwindemoel commented 1 year ago

I have the same issue. When is support for Angular 14 expected?

AbdealiLoKo commented 1 year ago

Same here.

alexvoss commented 1 year ago

It would be good if the latest from the version 13 and 14 releases could be supported. #59 is looking for support for 13.2. I have the same problem and am not sure if an upgrade to 14 will be done as it is not my decision. For me a bump to 13.2 would do the job.

On a related note: is the code really tied to a specific minor version? I note the tilde operator is used in the specification of the versions (see above) as opposed to the caret. Is this necessary? Since this is the default behavior of --save perhaps this is not intentional?

michaelbazos commented 1 year ago

Version 6.4.0 was published to npm registry.

@alexvoss If I remember correctly the use of the tilde came from the angular-cli template back when creating the project. With the merge request chore: upgrade to angular 14, a caret is now used.

michaelbazos commented 1 year ago

Keeping the thread open for now, in case some issue related to this update arise.

moberwasserlechner commented 1 year ago

Unfortunately it does not seem to work. I will ahve a look and try to fix the peer dependencies

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: my-project@14.0.0-0
npm ERR! Found: @angular/common@14.0.5
npm ERR! node_modules/@angular/common
npm ERR!   @angular/common@"^14.0.5" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"~13.1.1" from angular-feather@6.4.0
npm ERR! node_modules/angular-feather
npm ERR!   angular-feather@"^6.4.0" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See C:\Users\oberwmi1\AppData\Local\npm-cache\eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
sherlylina commented 1 year ago

npm ERR! code ERESOLVE npm ERR! ERESOLVE unable to resolve dependency tree npm ERR! npm ERR! While resolving: cust-video-conference@0.0.0 npm ERR! Found: @angular/common@13.1.3 npm ERR! node_modules/@angular/common npm ERR! @angular/common@"~13.1.0" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer @angular/common@"^14.0.4" from angular-feather@6.4.1 npm ERR! node_modules/angular-feather npm ERR! angular-feather@"^6.1.0" from the root project npm ERR! npm ERR! Fix the upstream dependency conflict, or retry npm ERR! this command with --force, or --legacy-peer-deps npm ERR! to accept an incorrect (and potentially broken) dependency resolution. npm ERR! npm ERR! See C:\Users\sherl\AppData\Local\npm-cache\eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in: npm ERR! C:\Users\sherl\AppData\Local\npm-cache_logs\2022-07-19T09_44_33_468Z-debug.log

Please it would be good if the angular version 13, 12, 10 could be also supported :)