search

michaelbonds / ship-station

A php wrapper for ShipStation's api.
10 stars 32 forks source link

Not all API endpoints available - 'accounts' #8

Open billda opened 4 years ago

billda commented 4 years ago

I am trying to make a call to the '/accounts/listtags' endpoint, but don't see 'accounts' as an available Endpoint in the code. Possible to get it added?

zack6849 commented 4 years ago

@billda Could you test out this dev branch on my fork and let me know if this works? (I don't have a partner account :) )

zack6849/ship-station:dev-add-accounts-endpoints

If it works, let me know and i'll release a new version with support for this.

Thanks!

billda commented 4 years ago

Gave it a shot, but still getting this error:

Undefined property: MichaelB\ShipStation\ShipStationApi::$accounts

Reason being because I don't think you've explicitly exposed ->accounts in ShipStationApi.php

zack6849 commented 4 years ago

Hi @billda ,

Thanks for the heads up, oops!

I just pushed a commit to fix that (I think)

Want to try again and let me know?

Thanks,

zack6849 commented 4 years ago

Hi @billda sorry to ping you again, but did you have a chance to check out if the newer revision fixed it?

If so, i'd like to merge my branch and publish a new version