search

michaelbromley / angularUtils

A place where I will collect useful re-usable Angular components that I make
MIT License
2k stars 858 forks source link

Vendor folder is missing angular-mocks and angular-ui-router to run unit tests #179

Open Muppets opened 9 years ago

Muppets commented 9 years ago

I was looking at add a feature to your awesome pagination directive. My first step for this was to get the existing unit tests up and running on grunt. When I ran the tests they failed with two warnings saying:

Running "karma:unit" (karma) task
WARN [watcher]: Pattern "C:/Work/angularUtils/vendor/angular-mock/angular-mock.js" does not match any file.
WARN [watcher]: Pattern "C:/Work/angularUtils/vendor/angular-ui-router/release/angular-ui-router.js" does not match any file.

I managed to dig up these files and get the unit tests passing but it might be handy if these were included in your vendor folder on GitHub.

Keep up the awesome work!

michaelbromley commented 9 years ago

Hi,

Thanks for that - actually the vendor folder should probably be omitted altogether from the repo, and we should instead rely on bower install to populate it. Looks like the bowerfile is incomplete anyway - it doesn't include jQuery, which is used in the unit tests.

I'll mark this as one to fix next time I get a bit of time.