search

michaelbromley / ngx-pagination

Pagination for Angular
http://michaelbromley.github.io/ngx-pagination/
MIT License
1.21k stars 245 forks source link

Adding overflow height to bottom #385

Open SrkaLo92 opened 2 years ago

SrkaLo92 commented 2 years ago

Hi, thanks for contributing!

This project is maintained in my spare time, so in order to help me address your issue as quickly as possible, please provide as much of the following information as you can.

-- Michael

[^ delete this message]

=======

*Angular version2.1.4*:

*ngx-pagination version5.1.1*:

I just implement pagination to my project, and everything works fine, but for some reason there is some height on bottom of pagination-controls. I checked css, and I cannot find solution.

Here is the link of screen record: https://youtu.be/SzxCwi48ozE

michaelbromley commented 2 years ago

Hi, I get "video unavailable" at that link.

SrkaLo92 commented 2 years ago

Hello,

Here is the link https://youtu.be/SzxCwi48ozE

On Mon, 31 Jan 2022 at 11:18, Michael Bromley @.***> wrote:

Hi, I get "video unavailable" at that link.

— Reply to this email directly, view it on GitHub https://github.com/michaelbromley/ngx-pagination/issues/385#issuecomment-1025580511, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOTLZHDQXWDVONOWFPZXMGTUYZOXZANCNFSM5NBHVHSQ . You are receiving this because you authored the thread.Message ID: @.***>

michaelbromley commented 2 years ago

OK thanks. Can you reproduce it in a StackBlitz demo?

SrkaLo92 commented 2 years ago

I am not sure, because that app belongs to the company. Can i send you code on some other way ?

On Mon, Jan 31, 2022 at 1:59 PM Michael Bromley @.***> wrote:

OK thanks. Can you reproduce it in a StackBlitz demo https://stackblitz.com/edit/angular-e1f9hq?

— Reply to this email directly, view it on GitHub https://github.com/michaelbromley/ngx-pagination/issues/385#issuecomment-1025712655, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOTLZHD3LWG5QHZK4UYHIX3UY2BS7ANCNFSM5NBHVHSQ . You are receiving this because you authored the thread.Message ID: @.***>

michaelbromley commented 2 years ago

You don't need to provide all your proprietary code. Just a minimal reproduction. If you can isolate the minimum code which will reproduce the issue, I have a much better chance of being able to spot what might be causing it.

SrkaLo92 commented 2 years ago

https://github.com/SrkaLo92/test-project Here is the repo of app.

On Mon, Jan 31, 2022 at 6:36 PM Michael Bromley @.***> wrote:

You don't need to provide all your proprietary code. Just a minimal reproduction. If you can isolate the minimum code which will reproduce the issue, I have a much better chance of being able to spot what might be causing it.

— Reply to this email directly, view it on GitHub https://github.com/michaelbromley/ngx-pagination/issues/385#issuecomment-1026033945, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOTLZHG2E2INYVKWWC2OGCDUY3CAHANCNFSM5NBHVHSQ . You are receiving this because you authored the thread.Message ID: @.***>

SrkaLo92 commented 2 years ago

If you have some questions, just let me know. You can contact me on whatsapp/telegram/viber +381655415128

On Tue, Feb 1, 2022 at 6:36 PM Srdjan Marinkovic < @.***> wrote:

https://github.com/SrkaLo92/test-project Here is the repo of app.

On Mon, Jan 31, 2022 at 6:36 PM Michael Bromley @.***> wrote:

You don't need to provide all your proprietary code. Just a minimal reproduction. If you can isolate the minimum code which will reproduce the issue, I have a much better chance of being able to spot what might be causing it.

— Reply to this email directly, view it on GitHub https://github.com/michaelbromley/ngx-pagination/issues/385#issuecomment-1026033945, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOTLZHG2E2INYVKWWC2OGCDUY3CAHANCNFSM5NBHVHSQ . You are receiving this because you authored the thread.Message ID: @.***>

michaelbromley commented 2 years ago

Hi, I'm afraid I don't have time to install, explore and investigate an entire repo of that size. That's why I ask for a minimal reproduction, i.e. the absolute bare minimum code which reproduces the issue. Ideally an app with a single component and no other 3rd party libs (unless they are required to reproduce the issue).

This step - building a minimal reproduction - can take a little bit of time. However, in doing so, quite often you will come to figure out the cause of the issue for yourself. And if not, the hour or so you spend on putting it together represents an equivalent time saving for me. Is my time more valuable than yours? Not necessarily! But in this case, you have more interest in solving the issue than I do, so it makes sense. Doing it any other way makes OSS very burdensome on maintainers.

So again, here's the Stackblitz demo which you can use as a starting point in putting together a minimal reproduction.