search

michaelbull / kotlin-result

A multiplatform Result monad for modelling success or failure operations.
ISC License
1.05k stars 63 forks source link

More Kotlin1.4 migration things #31

Closed Munzey closed 4 years ago

Munzey commented 4 years ago

Added explicitApi() so publicly exposed api functions needed to be explicitly declared public and all required return types.

Removed redundant kotlinx and stdlib dependencies. To do that I actually had to bump coroutines to 1.3.9 (they didn't make that very clear from the changelist 🤔 ).

michaelbull commented 4 years ago

Thanks @Munzey, but can we split this change into two commits?

We have two logically separate changes here:

  1. Removal of unnecessary third party libraries which will reduce our footprint
  2. Adoption of the explicit API mode

The former is more important and doesn't rely on the latter.

Munzey commented 4 years ago

dependencies change now in separate pr #32