search

michaelbull / kotlin-result

A multiplatform Result monad for modelling success or failure operations.
ISC License
1.02k stars 57 forks source link

Upping Kotlin version to 1.5.10 #56

Closed MrBergin closed 3 years ago

MrBergin commented 3 years ago

Hello there, first of all wanted to say I'm excited this repo exists! I was thinking of writing exactly this today!

I'm interested in using this library but want to use the latest Kotlin, figured I'd give it a go myself. In addition to upping to the latest Kotlin version I've upped the coroutines version to recommended one (1.5.0)

One thing that's confused me is upping the Coroutines version caused an overload ambiguity for CancellationException(null) in SuspendableBinding (line 40).

I've cast the null to a String? since I expect that's the behaviour currently, though I'm confused why upping the version caused this since it looks like a Throwable? overload has existed for native/js since coroutines 1.1.

All I've done is run the tests and verify they pass, if there's extra checking involved around upping this version I'd be happy to give it a go :)

michaelbull commented 3 years ago

Thanks! Merged in d64837f2f8171749ab391f9b40dcf10c11ec65f9