search

michaelcpuckett / activity-kit

An attempt to build a spec-compliant ActivityPub core library.
MIT License
96 stars 5 forks source link

Avoid hanging on uncaught errors #9

Closed michaelcpuckett closed 1 year ago

michaelcpuckett commented 1 year ago

Per @gobengo:

activitypub-core-server-express should probably catch unexpected exceptions in the endpoint respond methods and pass the error to express's next(err) callback. without that, express will hang on uncaught errors because res.end() is never called

michaelcpuckett commented 1 year ago

I think this is covered now, but will re-open if anyone has any suggestions!