search

michaeldera / image-accessibility-extension

A Google Chrome and Microsoft Edge extension to add alt attributes to images on webpages without them
MIT License
6 stars 3 forks source link

refactored for Jest tests #11

Closed nadchif closed 4 years ago

nadchif commented 4 years ago

I refactored the code for Jest unit tests. Submitting this as PR so you can review easily and share your thoughts/feedback before merging to development

michaeldera commented 4 years ago

Looks good to me, however I did not actually do a test on my local machine.

With regards to packaging, we are still doing that the same way?

nadchif commented 4 years ago

You deleted the licence, may you add that back?

I am sorry 🙈 . Moments like this i am happy I went with a Pull Request + Review request. Thank you for bringing that to my attention

michaeldera commented 4 years ago

All good. Thank you again. I will try and finish my commitments on the backend.

nadchif commented 4 years ago

once again, a pleasure 🙏